[In-App Purchases] Sandbox billing mode warnings #8123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toupper
added
type: task
Collaborator
You can test the changes from this Pull Request by:
|
koke
reviewed
Nov 15, 2022
Member
koke
left a comment
koke
left a comment
There was a problem hiding this comment.
I don't know if I'd add an alert every single time you try to purchase. Could we look first at whether wpcom-api-base-url is set and maybe replace the whole thing with the warning if it's not? That seems less intrusive and would work as long as we don't want to use this to test in production.
…e sandbox environment url is not setup.
Generated by 🚫 dangerJS |
Contributor
Author
|
@koke Sure, please take a look now. |
# Conflicts: # WooCommerce/Classes/ViewRelated/InAppPurchases/InAppPurchasesDebugView.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8122
Description
As we had a few test IAP transactions that ended up in production because the sandbox billing mode was not enabled when testing,
I wanted to propose the addition of a warning text and an alert reminder before purchasing a product in our IAP debug screen.we add a warning text instead of the IAP Debug Menu if the sandbox URL was not set in the WooCommerce Xcode schema.Testing instructions
No WPCOM Sandbox URL in the WooCommerce schema environment variable
Open the IAP Debug screen. A warning text should appear instead of the IAP Debug menu:
WPCOM Sandbox URL in the WooCommerce schema environment variable is setup
Open the IAP Debug screen. You should see the IAP Debug Menu as usual.
RELEASE-NOTES.txtif necessary.